Add support for attributes on types in WebIDL #22958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heads up! This PR modifies the following files:
|
|
r=me once squashed. |
Manishearth
force-pushed
the
attrs-on-types
branch
from
d119cfd
to
7b48df5
Compare
|
@bors-servo r=nox |
|
📌 Commit 7b48df5 has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Mar 4, 2019
Add support for attributes on types in WebIDL WebIDL moved `[Clamp]`, `[RangeEnforced]`, and `[TreatNullAs]` to applying directly to types in whatwg/webidl#286. I implemented parser support for this upstream in [bug 1359269](https://bugzilla.mozilla.org/show_bug.cgi?id=1359269). This pull request downstreams those changes and updates codegen as well as any webidls to conform. Needed to land #22874 r? @nox <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22958) <!-- Reviewable:end -->
|
☀️ Test successful - android-mac, arm32, arm64, linux-rel-css, linux-rel-wpt, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, magicleap, status-taskcluster |
highfive
removed
the
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Mar 4, 2019
Add support for MediaTrackConstraints This uses the WebIDL attributes-on-types support landed in #22958 to fill out the MediaTrackConstraints dictionary for constraints that servo-media supports. r? @jdm <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22874) <!-- Reviewable:end -->
bors-servo
pushed a commit
that referenced
this pull request
Mar 4, 2019
Add support for MediaTrackConstraints This uses the WebIDL attributes-on-types support landed in #22958 to fill out the MediaTrackConstraints dictionary for constraints that servo-media supports. r? @jdm <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22874) <!-- Reviewable:end -->
bors-servo
pushed a commit
that referenced
this pull request
Mar 4, 2019
Add support for MediaTrackConstraints This uses the WebIDL attributes-on-types support landed in #22958 to fill out the MediaTrackConstraints dictionary for constraints that servo-media supports. r? @jdm <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22874) <!-- Reviewable:end -->
bors-servo
pushed a commit
that referenced
this pull request
Mar 4, 2019
Add support for MediaTrackConstraints This uses the WebIDL attributes-on-types support landed in #22958 to fill out the MediaTrackConstraints dictionary for constraints that servo-media supports. r? @jdm <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22874) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WebIDL moved
[Clamp],[RangeEnforced], and[TreatNullAs]to applying directly to types in whatwg/webidl#286.I implemented parser support for this upstream in bug 1359269. This pull request downstreams those changes and updates codegen as well as any webidls to conform.
Needed to land #22874
r? @nox
This change is